Skip to content

haskell.packages.ghc98.ghc-lib{,-parser}: 9.8.2.20240223 -> 9.8.3.20241022#350904

Closed
mpscholten wants to merge 1 commit intoNixOS:haskell-updatesfrom
mpscholten:update-ghc-lib
Closed

haskell.packages.ghc98.ghc-lib{,-parser}: 9.8.2.20240223 -> 9.8.3.20241022#350904
mpscholten wants to merge 1 commit intoNixOS:haskell-updatesfrom
mpscholten:update-ghc-lib

Conversation

@mpscholten
Copy link
Copy Markdown
Contributor

@mpscholten mpscholten commented Oct 24, 2024 •
edited
Loading

The new version of ghc-lib was released recently. With this we should be able to switch to ghc983 in nixpkgs

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Oct 24, 2024
@mpscholten mpscholten marked this pull request as ready for review October 24, 2024 09:28
@maralorn
Copy link
Copy Markdown
Member

maralorn commented Oct 24, 2024

Yes, great. We are currently waiting on staging-next getting merged into master so that we can do our next round of bumps.

@mpscholten
Copy link
Copy Markdown
Contributor Author

mpscholten commented Oct 24, 2024 •
edited
Loading

As staging-next has not been merged into master yet, could we merge this PR into staging-next and then switch to GHC 9.8.3 in staging-next? This way we would get to use 9.83. faster :)

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 24, 2024
@maralorn
Copy link
Copy Markdown
Member

maralorn commented Oct 24, 2024

Good question. I don’t know. I have to say I am not super in a rush with this. I am very certain that we will get this in for the next release.

@sternenseemann wdyt?

@maralorn
Copy link
Copy Markdown
Member

maralorn commented Oct 25, 2024

This PR edits the autogenerated hackage-packages.nix file manually. But I think it’s obsoleted by the auto-update anyway.

@maralorn maralorn closed this Oct 25, 2024
@sternenseemann
Copy link
Copy Markdown
Member

sternenseemann commented Oct 25, 2024

Now that I've done the proper bump independently, I've also discovered that this change wouldn't even be enough to successfully compile HLS with GHC 9.8.3.

@mpscholten
Copy link
Copy Markdown
Contributor Author

mpscholten commented Oct 26, 2024

Thanks for looking into this 👍 Yes i haven't checked that HLS actually compiles after ghc-lib-parser was compiling.

@mpscholten mpscholten deleted the update-ghc-lib branch October 26, 2024 09:15
@mpscholten mpscholten mentioned this pull request Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maralorn maralorn Awaiting requested review from maralorn

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpscholten @maralorn @sternenseemann